ci(docs): bump the SHA-pinned Pages actions to their Node 24 majors - #316
Conversation
The tag-pinned actions moved to their node24 majors in #97, but docs.yml pins by SHA and was left out of that sweep, so it still logs: Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24 ... Bump all four, keeping the SHA pinning this file deliberately uses: actions/checkout v4.1.1 -> v7.0.1 actions/setup-node v4.0.3 -> v7.0.0 actions/upload-pages-artifact v3.0.1 -> v5.0.0 actions/deploy-pages v4.0.5 -> v5.0.0 upload-pages-artifact is a composite; what matters for the warning is the actions/upload-artifact@v7.0.0 it now calls internally, which is node24. The one real behavior change is upload-pages-artifact v4, which stopped bundling dotfiles. Docusaurus writes a `.nojekyll` into website/build, so that would have silently dropped it. The artifact-based Pages deploy never runs Jekyll and would most likely not care, but that is not worth verifying on the live site: `include-hidden-files: true` (added in v5) restores exactly what v3 uploaded. `.git` and `.github` stay excluded regardless. Changing this file matches the workflow's own `paths` filter, so the build and upload steps are exercised by this PR. The deploy job only runs on push to main and stays unvalidated until merge — it is a pure runtime bump, with no input or output changes between v4.0.5 and v5.0.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 17 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Problem
#97 moved every tag-pinned action to its Node 24 major.
docs.ymlpins by SHA instead, so it was left out of that sweep and still logs:Fix
Bump all four, keeping the SHA pinning this file deliberately uses:
actions/checkoutactions/setup-nodeactions/upload-pages-artifactactions/deploy-pagesupload-pages-artifactis a composite action, so its ownusing:iscomposite; what matters for the warning is theactions/upload-artifact@v7.0.0it calls internally, which isnode24. The other three were verified asnode24by readingaction.ymlat each pinned SHA.The one real behavior change
upload-pages-artifactv4 stopped bundling dotfiles. Docusaurus writes a.nojekyllintowebsite/build, so this bump would have silently dropped it.The artifact-based Pages deploy never runs Jekyll, so losing it would most likely be harmless — but that is not something worth confirming on the live site.
include-hidden-files: true(added in v5) restores exactly what v3 uploaded..gitand.githubstay excluded either way.Validation
Changing this file matches the workflow's own
pathsfilter, so the build and upload steps run on this PR.The
deployjob only runs on push tomain, so it stays unvalidated until merge. That is the residual risk, and it is small:v4.0.5 → v5.0.0is a pure runtime bump with no input or output changes.Not covered
ilammy/msvc-dev-cmd@v1inbuild-whisper-stt.ymlis the last remainingnode20reference in the repo. Upstream is abandoned (last push April 2024, two open "update to Node 24" PRs unmerged), so there is nothing to bump to — tracked separately.🤖 Generated with Claude Code